Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should SystemDictionary sort classes by name? #4204

Closed
jecisc opened this issue Aug 6, 2019 · 3 comments
Closed

Should SystemDictionary sort classes by name? #4204

jecisc opened this issue Aug 6, 2019 · 3 comments

Comments

@jecisc
Copy link
Member

jecisc commented Aug 6, 2019 •
edited

I was doing some profiling today and I found that when you call #allBehaviors it access to a cache, but during the build of the cache it sorts the class names.

I am wondering if it should be the responsibility of the SystemDictionary to sort the cache.

I would expect the model to return unsorted collection and the UI should sort it if needed.
@MarcusDenker
Copy link
Member

No, I think it should not: sorting is a client (and mostly even UI) issue.

@MarcusDenker
Copy link
Member

PR: #4274

@MarcusDenker
Copy link
Member

merged after review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcusDenker @jecisc