Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digitLength should be renamed #4583

Closed
pavel-krivanek opened this issue Sep 13, 2019 · 2 comments · Fixed by #4585
Closed

digitLength should be renamed #4583

pavel-krivanek opened this issue Sep 13, 2019 · 2 comments · Fixed by #4585

Comments

@pavel-krivanek
Copy link
Collaborator

Guess, what is the result of 333 digitLength? It is 2, of course ;-) You are supposed to use decimalDigitLength
We should rename this method to something less confusing, e.g. bytesCount.
While it is so confusing, it would be better to remove it without deprecation but it is used quite a lot so we shall use auto-deprecation
@pavel-krivanek pavel-krivanek mentioned this issue Sep 13, 2019
Merged
@Ducasse
Copy link
Member

Ducasse commented Sep 13, 2019

Thanks for cleaning this.
All this cruft accumulated over the years.!!!!
TXTXTXTXTXTXTX

@dionisiydk
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4583-digitLength-should-be-renamed pavel-krivanek/pharo
3 participants
@Ducasse @pavel-krivanek @dionisiydk