Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing in build: testExternalMorphicDependencies #4818

Closed
MarcusDenker opened this issue Oct 4, 2019 · 4 comments · Fixed by #4824
Closed

Test failing in build: testExternalMorphicDependencies #4818

MarcusDenker opened this issue Oct 4, 2019 · 4 comments · Fixed by #4824

Comments

@MarcusDenker
Copy link
Member

Given Collections do not match! additions : #(#'WebBrowser-Core') missing: #()
Stacktrace
SystemDependenciesTest(TestAsserter)>>assert:description:resumable:
SystemDependenciesTest(TestAsserter)>>assert:description:
SystemDependenciesTest(TestAsserter)>>assertCollection:hasSameElements:
SystemDependenciesTest>>testExternalMorphicDependencies

@MarcusDenker
Copy link
Member Author

A lot of dependency tests are failing:

testExternalDisplayDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest
testExternalMetacelloDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest
testExternalMorphicCoreDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest
testExternalMorphicDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest
testExternalSUnitDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest
testExternalUFFIDependencies – Windows32.System.DependenciesTests.SystemDependenciesTest

@MarcusDenker
Copy link
Member Author

introduced by: #4715

@MarcusDenker
Copy link
Member Author

actOnClick: anEvent for: anObject in: paragraph editor: editor

references WebBrowser

@MarcusDenker
Copy link
Member Author

we could implement it as

actOnClick: anEvent for: anObject in: paragraph editor: editor
self class environment
at: #WebBrowser
ifPresent: [ :webBrowser | webBrowser openOn: url ]
ifAbsent: [ self
inform:
('Cannot open "{1}" because the project WebBrowser is not present by default in Pharo.'
format: {url}) ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant