Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector should not open blindly any file without asking the user #5187

Closed
VincentBlondeau opened this issue Nov 20, 2019 · 6 comments
Closed
Labels
Company: Lifeware Project: Large Images to make sure that pharo IDE can react when used with large images Status: Question

Comments

@VincentBlondeau
Copy link
Contributor

We should be a limit on the size of the file like 500 ko or 1Mo before showing a popup.

@bencoman
Copy link
Contributor

Thats only saying what should be done, not what the problem is.
What are the steps to reproduce and what behaviour is observed?

@Ducasse
Copy link
Member

Ducasse commented Nov 21, 2019

Try to open a file of multiple mb in the inspector.
FOr example a dot.st file of 124Mb

@Ducasse Ducasse added the Project: Large Images to make sure that pharo IDE can react when used with large images label Jan 22, 2020
@MarcusDenker MarcusDenker added this to To do in Large Images Feb 4, 2020
@VincentBlondeau
Copy link
Contributor Author

Problem is now handled for most of the file (only the first bytes are shown in the inspector).
Except the .zip files: opening a large one still have issues.
Coming from: AbstractFileReference >> inspectionCompressedItems

@estebanlm
Copy link
Member

Try to open a file of multiple mb in the inspector.
FOr example a dot.st file of 124Mb

this is in fact working (or should) : contents are cut at 10k always.

@estebanlm
Copy link
Member

Problem is now handled for most of the file (only the first bytes are shown in the inspector).
Except the .zip files: opening a large one still have issues.
Coming from: AbstractFileReference >> inspectionCompressedItems

this is a problem that happens when you have a lot of files, then... since this is a table to show contents.
You have :

children := root directories, root files.

and it seems that's the problem (collecting the entries).

can you confirm this is the case?

@fedemennite
Copy link

This doesn't seem an issue for us anymore.
Can be closed at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Company: Lifeware Project: Large Images to make sure that pharo IDE can react when used with large images Status: Question
Projects
Large Images
  
To do
Development

No branches or pull requests

7 participants