Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger crashes for any Warning - emergency evaluator opens instead #5545

Closed
JanBliznicenko opened this issue Jan 22, 2020 · 7 comments
Closed
Labels
Priority: Critical To fix or review as soon as possible

Comments

@JanBliznicenko
Copy link
Contributor

JanBliznicenko commented Jan 22, 2020

In latest images of Pharo 8 and 9 (including the "main" ones in Pharo Launcher), whenever debugger should open for Warning, it does not and emergency evaluator opens instead.

2020-01-22

In Pharo 8, it happens since build 1121.sha.bbcdf97 (commit bbcdf97 ).
Build 1120.sha.c115bf4 (commit c115bf4 ) is ok.
On Windows, Linux and Mac.

Steps to reproduce:

  1. Get clean latest Pharo 8 image.
  2. Run self notify: 'hi' or anything else that should signal any warning.
@JanBliznicenko JanBliznicenko changed the title Debugger does not open - emergency evaluator opens instead Debugger crashes for any Warning - emergency evaluator opens instead Jan 22, 2020
@MarcusDenker
Copy link
Member

GTSpecPredebugActionPresenter>>#initializeWidgets calls non existing method #presenterAt:put:

@MarcusDenker
Copy link
Member

It seems the pull request that did that was #5513

@MarcusDenker MarcusDenker added the Priority: Critical To fix or review as soon as possible label Jan 22, 2020
@MarcusDenker
Copy link
Member

It seems there is a trait missing in the GTSpecPreDebugActionsPresenter class, if I do this, it works:

SpPresenter subclass: #GTSpecPreDebugActionsPresenter
uses: SpTDynamicPresenter
instanceVariableNames: ''
classVariableNames: ''
package: 'GT-Debugger-UI'

@JanBliznicenko
Copy link
Contributor Author

I tried new image and it is fixed, thank you

@JanBliznicenko
Copy link
Contributor Author

JanBliznicenko commented Jan 24, 2020

I decided to reopen the issue until this fixed build is put as stable here:
https://files.pharo.org/image/80/stable-64.zip
and here:
https://files.pharo.org/image/80/stable-32.zip
because these are the links Pharo Launcher takes "official" images (that everybody downloads) from, as you can see here:
https://github.com/pharo-project/pharo-launcher/blob/master/sources.list

@seandenigris
Copy link
Contributor

A new 8.0.1 release has been tagged, but the URL still downloads 8.0.0 (bbcdf97). Is there another step?

@estebanlm
Copy link
Member

There is an error in the CI and it did not uploaded the stable*.zip archives (while it did the latest).
I uploaded them by hand but we need to review the process (problem is now I cannot test it in my machine anymore, I need to prepare an environment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical To fix or review as soon as possible
Projects
None yet
Development

No branches or pull requests

4 participants