Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReSentNotImplementedRule should return a smell if the only sender is the same method #5970

Closed
jecisc opened this issue Mar 23, 2020 · 2 comments · Fixed by #12585
Closed

ReSentNotImplementedRule should return a smell if the only sender is the same method #5970

jecisc opened this issue Mar 23, 2020 · 2 comments · Fixed by #12585
Labels
Type: Bug

Comments

@jecisc
Copy link
Member

jecisc commented Mar 23, 2020

While removing dead code I found multiple times methods that were not detected as smells by RBImplementedNotSentRule. The reason is that they had a sender that is themself.

I think that in that case, the smell should still be raised.
@guillep guillep changed the title RBImplementedNotSentRule should return a smell if the only sender is self RBImplementedNotSentRule should return a smell if the only sender is the same method Mar 27, 2020
@myroslavarm
Copy link
Contributor

I cannot find this rule btw. Has it been removed?

@MarcusDenker
Copy link
Member

it is now called ReSentNotImplementedRule

@MarcusDenker MarcusDenker changed the title RBImplementedNotSentRule should return a smell if the only sender is the same method ReSentNotImplementedRule should return a smell if the only sender is the same method Apr 27, 2020
@MarcusDenker MarcusDenker removed the Easy label Feb 2, 2021
@jecisc jecisc mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ReImplementedNotSentRule to ignore self calls + add tests jecisc/pharo
4 participants
@MarcusDenker @guillep @jecisc @myroslavarm