Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UITestCase #6083

Closed
astares opened this issue Mar 31, 2020 · 0 comments · Fixed by #6084
Closed

Improve UITestCase #6083

astares opened this issue Mar 31, 2020 · 0 comments · Fixed by #6084

Comments

@astares
Copy link
Member

astares commented Mar 31, 2020 •
edited

Class comment says "All instances of UITestCase are skipped in headless mode" which is not correct
because tests of subclasses are skipped.
So basically UITestCase is an abstract test superclass.

We should

  1. implement a class side #isAbstract method
isAbstract
     ^self == UITestCase
  1. Change the class comment to
This is an abstract superclass for all tests requiring a user interface (UI). The tests are skipped when Pharo runs in headless mode.
  1. Possibly even rename the class into AbstractUITestCase

Step 1 and 2 should be done, step 3 is optional but would make it more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve UITestCase astares/pharo
1 participant
@astares