Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Breakpoints: Wrong Icon in gutter #7535

Closed
MarcusDenker opened this issue Oct 21, 2020 · 0 comments · Fixed by #7551
Closed

Variable Breakpoints: Wrong Icon in gutter #7535

MarcusDenker opened this issue Oct 21, 2020 · 0 comments · Fixed by #7551

Comments

@MarcusDenker
Copy link
Member

Describe the bug
When adding a breakpoint for a variable, the icon is wrong

To Reproduce
Steps to reproduce the behavior:

  1. select some ivar use in a method
  2. menu, Debugging, "break on read to var"
  3. See Metalink icon at the right, not the icon for breakpoints

Expected behavior
We should get only a Breakpoint icon

We did fix this for "normal" breakpoint. There the reason was that in #install, we were adding the metalink
before adding the breakpoint to the #breakpoints annotation on the AST node.

If we check the situation here, this is not possible as the link only knows after it has places where it will be placed

First thing to check: does #hasBreakpoint return true after adding the breakpoint to the variable?

@MarcusDenker MarcusDenker added this to To do in Debugger and Debugging via automation Oct 21, 2020
@MarcusDenker MarcusDenker linked a pull request Oct 23, 2020 that will close this issue
Debugger and Debugging automation moved this from To do to Done Oct 25, 2020
@StevenCostiou StevenCostiou moved this from Done to Closed issues in Debugger and Debugging Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Debugger and Debugging
  
Closed issues
Development

Successfully merging a pull request may close this issue.

1 participant