Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste shortcut (cmd/ctrl+V) conflicts with new calypso shortcut #8855

Closed
guillep opened this issue Mar 22, 2021 · 0 comments · Fixed by #8856
Closed

Paste shortcut (cmd/ctrl+V) conflicts with new calypso shortcut #8855

guillep opened this issue Mar 22, 2021 · 0 comments · Fixed by #8856

Comments

@guillep
Copy link
Member

guillep commented Mar 22, 2021

Bug description

In calypso, sometimes copy-pasting freezes entirely the text input.

To Reproduce

I got to reliably reproduce it since build 1198 by doing:

  • Copy this in Calypso, for example in the class CoResultSet
acceptsContents: stringWithContentsToBeAccepted usingFilterString: filterString
	
	aString isEmpty or: [ e contents beginsWith: aString ] ].
			results := results select: [ :e | aString isEmpty or: [ e contents beginsWith: aString ] ] ]
		ifFalse: [
			"Smaller filter, reset results and filter"
			results := OrderedCollection new.
			fetcher reset.
			fetcher := fetcher select: [ :e | aString isEmpty or: [ e contents beginsWith: aString ] ].
		].
	completionString := aStringng
  • Copy "filterString"
  • select the second occurrence of aString (the one inside [ e contents beginsWith: aString ] ].
  • paste

Not only it does not paste anymore, but also all text input is kinda broken

Version information:
I chased the bug to build 1198, which includes the following PRs

image

It seems the culprit is 2d37110
Which introduces some shortcut conflicts on Cmd/Ctrl+V

SycMergeVariableCommand class >> fullBrowserShortcutActivation [
	<classAnnotation>

	^CmdShortcutActivation by: $v meta, $m meta for: ClyFullBrowserVariableContext
]

SycMergeVariableCommand class >> sourceCodeShortcutActivation [
	<classAnnotation>

	^CmdShortcutActivation by: $v meta, $m meta for: ClySourceCodeContext 
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant