Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderBugsTest>>#testForward: checks for timing, leads to timeouts on slow CI #9922

Closed
MarcusDenker opened this issue Sep 8, 2021 · 2 comments

Comments

@MarcusDenker
Copy link
Member

testForward checks that an operation takes a certain time:

testForward
	"If the bug exist there will be an infinte recursion."

	| t |
	cases := {(t := TransformationMorph new openCenteredInWorld)}.
	self shouldntTakeLong: [ self assert: t forwardDirection equals: 0.0 ]

This is a problem, as the machines that run the CI job are virtualized and can have very wonky timing characteristics.

Myabe #shouldntTakeLong: should use a higher value for timeout if running on the CI.

@MarcusDenker
Copy link
Member Author

we could even think about removing the class RenderBugsTest. I am not that of a fan of tests that test for specific fixed bugs (as opposed to unit tests that are added that fail due to a bug).

Tests like RenderBugsTest can be useful, but as soon as they mean work I am tempted to remove them.

@MarcusDenker
Copy link
Member Author

This is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant