Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowPresenter variable #model should be renamed #presenter #10

Closed
jecisc opened this issue Oct 3, 2018 · 2 comments
Closed

WindowPresenter variable #model should be renamed #presenter #10

jecisc opened this issue Oct 3, 2018 · 2 comments
Assignees
@jecisc
Labels
Cleaning enhancement

Comments

@jecisc
Copy link
Member

jecisc commented Oct 3, 2018

Don't forget the deprecation to not break current UIs
@estebanlm
Copy link
Member

why it should be ?
it isn't a model of the presenter, regardless it is a presenter itself?

@jecisc
Copy link
Member Author

jecisc commented Oct 3, 2018 •
edited
Loading

Before it pointed to a *Model, now Model suffix was renamed Presenter.

It's to make the difference between the real model used by the GUI and the adaptor that is part of the GUI.

@jecisc jecisc mentioned this issue Oct 3, 2018
Merged
@jecisc jecisc self-assigned this Oct 3, 2018
@jecisc jecisc added review and removed in progress labels Oct 3, 2018
@jecisc jecisc closed this as completed in #21 Oct 4, 2018
@jecisc jecisc removed the review label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jecisc jecisc

Labels
Cleaning enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estebanlm @jecisc