-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TonelWriter uses the platform line ending #99
Comments
I've been bitten by that too |
The decision to use platform-specific line endings was deliberate. If code is managed in Git, Git can (and should be configured to) adjust the line endings in the repository, so no changes are recorded in Git. From the draft Tonel spec (comments welcome) https://github.com/GemTalk/TonelSpec/blob/master/TonelSpec1.0-draft1.txt
|
indeed, as Martin says. |
TonelWriter
uses the platform line ending convention when writing new lines. This is problematic for projects with contributors using different OS versions.I have been bitted more than once with Pull Requests made from people using Windows because every little file looks like changed due to line endings.
I think it's better to settle into ONE line-ending convention for all the platforms. Any decent editor can read any of the line-ending formats so I don't see a problem here, and it will make project maintainers happier 😄 .
I propose to use the UNIX line-ending format given that is the native one in 2 of the 3 supported platforms.
The text was updated successfully, but these errors were encountered: