Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks are buggy #45

Open
phase opened this issue Nov 17, 2015 · 7 comments
Open

Permalinks are buggy #45

phase opened this issue Nov 17, 2015 · 7 comments

Comments

@phase
Copy link
Owner

phase commented Nov 17, 2015

Reopen this issue whenever Permalinks break

They're buggy and work only half the time. I think if we encode the request into base 64 and decode it in the POST request, we should be good.

@phase phase self-assigned this Nov 17, 2015
@phase phase closed this as completed in 16baae7 Nov 20, 2015
@phase
Copy link
Owner Author

phase commented Nov 21, 2015

Now they don't work on mobile.

@phase phase reopened this Nov 21, 2015
@phase
Copy link
Owner Author

phase commented Nov 21, 2015

Seems to only be iOS

@phase
Copy link
Owner Author

phase commented May 1, 2016

Base 64 doesn't work because we're separating the input and code with a forward slash. If the b64 encoding doesn't contain a slash, then it works.

@phase
Copy link
Owner Author

phase commented Jul 8, 2016

I don't have any test cases for code or inputs that, when Base 64 encoded, contain a /.

@refi64
Copy link
Collaborator

refi64 commented Sep 22, 2016

They don't seem to work at all anymore. :( Just gives a 404 error.

@phase
Copy link
Owner Author

phase commented Sep 23, 2016

The ones in the README work fine. What was the link you used? If it contains a / from the base64 encoding, it will give a 404 because it thinks it is going to a different path.

@refi64
Copy link
Collaborator

refi64 commented Sep 23, 2016

Oops, that was it. Maybe you should just do encodeURI on the base64 encoded stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants