Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload file [Windows 10] #26

Closed
tomclancyya opened this issue May 23, 2020 · 6 comments
Closed

Cannot upload file [Windows 10] #26

tomclancyya opened this issue May 23, 2020 · 6 comments
Labels
Bug Something isn't working
Milestone

Comments

@tomclancyya
Copy link

tomclancyya commented May 23, 2020

Steps to reproduce:

  1. launch PhaserEditor2D.exe -desktop
  2. create new project
  3. Rich-click on the assets folder and press the Upload Files option of the context menu.
  4. Click on the Browse button and select the image file in your computer.
  5. Press the Upload button.

what expected:
The image is uploaded to the assets folder and shown in the Files view.

what I got:
Alert window: error sending file

Server logs:

2020/05/23 20:13:06 Starting in Desktop mode
2020/05/23 20:13:06 Loading workspace at C:\PhaserEditor2D_V3\workPlace
2020/05/23 20:13:06 Listening at http://127.0.0.1:1959/editor
2020/05/23 20:13:06 Opening browser at http://127.0.0.1:1959/editor
2020/05/23 20:13:19 Upload to project folder: Game/assets
2020/05/23 20:13:19 Copying file C:\Users\name\AppData\Local\Temp\phasereditor-upload-561477607.tmp to C:\PhaserEditor2D_V3\workPlace/Game/assets/planet.png
2020/05/23 20:13:19 rename C:\Users\name\AppData\Local\Temp\phasereditor-upload-561477607.tmp C:\PhaserEditor2D_V3\workPlace/Game/assets/planet.png: The process cannot access the file because it is being used by another process.

How I tried to fixed:

  • turn off all antivirus
  • run cmd in administrator mode
  • change the workplace to c:\PhaserEditor2D_V3 to prevent any problems with path

PhaserEditor2d v3.0.1
GoogleChrome 83.0.4103.61

@PhaserEditor2D
Copy link
Owner

Thanks @tomclancyya for your detailed report.

@PhaserEditor2D PhaserEditor2D added this to the 3.1.0 milestone May 23, 2020
@PhaserEditor2D
Copy link
Owner

I will work on this soon, in the meantime, you can copy the files directly in the folder, without the Upload dialog. When you click/focus on the IDE, it will look for changes in the filesystem and show the new files.

@PhaserEditor2D PhaserEditor2D added Bug Something isn't working windows labels May 23, 2020
@tomclancyya
Copy link
Author

Roger that, thanks!

@PhaserEditor2D
Copy link
Owner

Hi @tomclancyya

The problem is that Windows does not allow the server to move the uploaded temporal file to the project folder.

I changed it and now it copies (not move) the file. Please, test this build and tell me if it works for you:

PhaserEditor2D-3.0.1-fixes-upload.zip

@tomclancyya
Copy link
Author

Hi @PhaserEditor2D
Tested, It works like a charm now!
Thanks for fixing!

@PhaserEditor2D
Copy link
Owner

Great! You are welcome.
We are going to release a new version in the few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants