Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmoothedKeyControl MinZoom vs BaseCamera minZoom #4649

Closed
giviz opened this issue Jul 12, 2019 · 1 comment
Closed

SmoothedKeyControl MinZoom vs BaseCamera minZoom #4649

giviz opened this issue Jul 12, 2019 · 1 comment

Comments

@giviz
Copy link

giviz commented Jul 12, 2019

Version

  • Phaser Version: Phaser v3.18.1-FB (WebGL)
  • Operating system: MAC OS
  • Browser:

Description

SmoothedKeyControl.js L449 min allowed zoom : 0.1
BaseCamera.js L1410 min allowed zoom : 0.001

Example Test Code

Just update SmoothedKeyControl.js to have also a min allowed zoom of 0.001

Additional Information

Thank you.

@photonstorm
Copy link
Collaborator

To be honest, the 0.001 value is only there to avoid a divide by zero error elsewhere in the code. In all practical uses, a zoom of 0.1 is already too tiny! However, there's no harm in making these match up, so I have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants