Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a task uniq id as an event attribute #19

Closed
dinoboff opened this issue Mar 21, 2015 · 5 comments
Closed

Add a task uniq id as an event attribute #19

dinoboff opened this issue Mar 21, 2015 · 5 comments

Comments

@dinoboff
Copy link
Contributor

Currently, events come with a uid attribute (to match a "start" event to a "stop"/"error" event) and the name (a provided string or the function name). The task name is not necessary unique.

Is it possible to add task id attribute unique to each task?

@phated
Copy link
Member

phated commented Mar 22, 2015

@dinoboff I am 👍 for this, how would you handle it? Just generate a uid inside undertaker.set?

@dinoboff
Copy link
Contributor Author

@phated it wouldn't cover private task used by series and parallel.

What about in buildTree?

@dinoboff
Copy link
Contributor Author

something like.

    meta = {
      name: name,
      uid: uid++,
      tree: {
        label: name,
        type: 'function',
        nodes: []
      }
    };

    metadata.set(task, meta);
    return meta.tree;

Would it cover all cases?

ps: series and parallel function would also need it

@dinoboff
Copy link
Contributor Author

the extension helper can handle it :)

@phated
Copy link
Member

phated commented Apr 12, 2015

I believe this is wrapped up as of 1810ec7

@phated phated closed this as completed Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants