Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding encryption and sighning algorithms #38

Closed
zharpaz-bmc-com opened this issue May 13, 2018 · 6 comments
Closed

Adding encryption and sighning algorithms #38

zharpaz-bmc-com opened this issue May 13, 2018 · 6 comments
Assignees
@phax
Labels
enhancement question

Comments

@zharpaz-bmc-com
Copy link
Contributor

Hi Philip,

We need to add AES256 and SHA-2. I will add them and issue a pull request. OK with you?

Thanks,
Ziv
@phax
Copy link
Owner

phax commented May 13, 2018

SHA-224, SHA-256, SHA-384 and SHA-512 are already supported!
See class ECryptoAlgorithmSign.

The PR for AES256 in ECryptoAlgorithmCrypt is appreciated.

@phax phax self-assigned this May 13, 2018
@zharpaz-bmc-com
Copy link
Contributor Author

Correct. My mistake regarding SHA-2. Sorry.

@phax
Copy link
Owner

phax commented May 15, 2018

No worries. Thanks for your help

@phax
Copy link
Owner

phax commented May 15, 2018

See PR #39

@phax
Copy link
Owner

phax commented May 15, 2018

You need a release now, or is there more to come?

@zharpaz-bmc-com
Copy link
Contributor Author

I will try to include support for large files. No need for release yet.
Thanks Phillip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @zharpaz-bmc-com