-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory optimisations #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assert helps to validate that the sequences outputted are the same in size.
When filtering VCF all records were kept in memory. This leads to huge memory consumption (~10G for 5Mb genome). Now, if *out_vcf* is specified for *VariantSet.filter_vcf* then as soon as record in filtered, it is written to the file. Thus reducing memory footprint, which is mostly python stuff now.
Some features have been disabled, but otherwise comporable result is returned from old version, but more memory friendly.
calculation. Distance matrix calculation is going to be done in a separate module.
ParallelVCFReader can now be found and used to travers multiple VCF readers one position at a time.
sample-gaps filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reworked the filtering and vcf2fasta steps that will allow more efficient memory usage (See #12)
TODO: