Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the same concept for imagePullSecrets as well #21

Open
rajivml opened this issue Jan 3, 2021 · 2 comments
Open

Extend the same concept for imagePullSecrets as well #21

rajivml opened this issue Jan 3, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rajivml
Copy link

rajivml commented Jan 3, 2021

HI,

Can we have this extended for imagePullSecrets as well, because in order to access an private registry , secret is also required.. If the same can be added through webhooks, that would be great

@rajivml rajivml added the enhancement New feature or request label Jan 3, 2021
@rajivml rajivml changed the title Can we extend the same concept for imagePullSecrets as well Extend the same concept for imagePullSecrets as well Jan 3, 2021
@phenixblue
Copy link
Owner

Hey @rajivml, thanks for reaching out. I think this feature is outside the scope of the project right now. I'll leave this open for a bit and see if anyone else comments to support this.

@phenixblue
Copy link
Owner

@rajivml I'm revisiting this to think through how it might work.

Still not sure it fits here, but wanted to get a better idea on what the expected functionality is.

Is the expectation that there would be some central source of image pull secrets (ie. all in one namespace), or would you want to be able to grab secrets from any namespace potentially?

My first thought was to add a second maps config file specific to imagePullSecrets that would follow a format like this:

<registry_fqdn>:<namespace>.<secret_name>

Example with multiple maps:

default:namespace.image-pull-secret1
quay.io:namespace2.quay-image-pull-secret

There are a lot of edges with this given that it would be replicating secrets across namespace bounds, but that may be ok in your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants