Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom key names for bring your own certificate #58

Open
jpuskar opened this issue Dec 29, 2021 · 1 comment
Open

support custom key names for bring your own certificate #58

jpuskar opened this issue Dec 29, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed python

Comments

@jpuskar
Copy link

jpuskar commented Dec 29, 2021

Hi,
It looks like the init sidecar is hard-coded to use cert.pem and tls.pem. This prevents one from using cert-manager to handle webhook certificates, for those of us who can't use the built-in k8s certificate generation (e.g. canonical charmed kubernetes default installation).

Would you consider allowing for an environment variable that replaces the strings 'cert.pem' and 'tls.pem' with a user-provided value?

Cert-manager uses tls.key, tls.crt, and ca.crt by default.

@jpuskar jpuskar added the enhancement New feature or request label Dec 29, 2021
@phenixblue
Copy link
Owner

I think this is something fairly simple we can do. I am returning from holiday and it will take me a bit to catch up on things, but I will try and take care of this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed python
Projects
None yet
Development

No branches or pull requests

2 participants