Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple theme strategies #177

Closed
cblavier opened this issue Nov 9, 2022 · 0 comments · Fixed by #182
Closed

Handle multiple theme strategies #177

cblavier opened this issue Nov 9, 2022 · 0 comments · Fixed by #182
Assignees
@cblavier
Milestone
0.5.0

Comments

@cblavier
Copy link
Contributor

cblavier commented Nov 9, 2022

Currently, theme is applied as a class to the body element and passed as assign to components.
We should be able to customize how theme will be passed to our components through different strategies :

  • body class (with custom class prefix)
  • assign (with custom assign name)
  • function call (module + function)
@cblavier cblavier added this to the 0.5.0 milestone Nov 9, 2022
@cblavier cblavier self-assigned this Nov 9, 2022
@cblavier cblavier linked a pull request Nov 14, 2022 that will close this issue
implemented theme strategies #182
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cblavier cblavier

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

implemented theme strategies phenixdigital/phoenix_storybook
1 participant
@cblavier