-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story files as .exs #2
Comments
Since all the storybook content is pre-compiled through macros, all stories would be executed at compile time to fetch their content. We wouldn't benefit much from this change. Would we? |
This is less about changing how those modules are used, if they're meant to be used, but more about that one probably doesn't really want those modules to continue to exist after compilation, in production, outside of the storybook, …. Just like test files are only compiled to run tests and only the ones which are actually executed. |
I think I got your point. |
I personally would probably keep them outside, but also it's not a clear cut picture. Phoenix templates (can be |
Thanks for your insight. I'll try it with (and you also deserve a special 🥇 for being the first issue opened here ;-) |
I'm really interested in this, so happy to help. I've been a big fan of fractal, but it's not really a great fit for elixir and I've also tried to build similar projects before, but never got them anywhere usable. |
I just looked through the README and noticed that the story files are
.ex
files, but one also needs to supply a path for where those files are. I'm wondering if those files should rather be.exs
files, so they're not compiled by default, but only used by the storybook. I feel like this is a similar setup to test files, which also are.exs
files.The text was updated successfully, but these errors were encountered: