Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core_components.story.exs broken #251

Closed
LostKobrakai opened this issue Feb 28, 2023 · 3 comments · Fixed by #267
Closed

core_components.story.exs broken #251

LostKobrakai opened this issue Feb 28, 2023 · 3 comments · Fixed by #267
Assignees

Comments

@LostKobrakai
Copy link
Contributor

LostKobrakai commented Feb 28, 2023

It still uses the rc field input syntax of field={{f, …}}.

The story rendered blank without showing an error and when trying to look at the source it showed an phoenix error. I think the rendering of the story should at least show that there was an error.

@justlampin
Copy link
Contributor

@LostKobrakai i believe this was fixed in #247

after the following steps, it appears to be generating the correct syntax in the core_components/input.story.exs file:

  • adding {:phoenix_storybook, "~> 0.5"} to mix.exs
  • mix deps.get
  • rm -rf storybook
  • mix phx.gen.storybook

for reference here's what's in my mix.lock file for this dependency:

"phoenix_storybook": {:hex, :phoenix_storybook, "0.5.0", "c70ae33f53adf54e0cb99271e7617cd5160d1b6780fc7bc50b6da2893bfbde3c", [:mix], [{:earmark, "~> 1.4", [hex: :earmark, repo: "hexpm", optional: false]}, {:heroicons, "~> 0.5", [hex: :heroicons, repo: "hexpm", optional: true]}, {:jason, "~> 1.3", [hex: :jason, repo: "hexpm", optional: true]}, {:makeup_eex, "~> 0.1.0", [hex: :makeup_eex, repo: "hexpm", optional: false]}, {:phoenix, "~> 1.7.0", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_live_view, "~> 0.18", [hex: :phoenix_live_view, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: false]}], "hexpm", "156a8c033819584cf9e79d04fefa864cf71f31e53afc02b5eaa14bf716e9224e"},

if you follow the same steps, does the issue persist?

@LostKobrakai
Copy link
Contributor Author

Where I saw the issue has been "0.5.0"

"phoenix_storybook": {:hex, :phoenix_storybook, "0.5.0", "c70ae33f53adf54e0cb99271e7617cd5160d1b6780fc7bc50b6da2893bfbde3c", …}

@cblavier cblavier self-assigned this Mar 14, 2023
@cblavier cblavier linked a pull request Mar 16, 2023 that will close this issue
@cblavier
Copy link
Contributor

I could reproduce the issue and just fixed it.
It will be released in 0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants