Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoenix aliases need to be adjusted #252

Closed
LostKobrakai opened this issue Feb 28, 2023 · 2 comments · Fixed by #266
Closed

Phoenix aliases need to be adjusted #252

LostKobrakai opened this issue Feb 28, 2023 · 2 comments · Fixed by #266
Assignees
@cblavier
Labels
enhancement New feature or request

Comments

@LostKobrakai
Copy link
Contributor

LostKobrakai commented Feb 28, 2023 •
edited

The instructions should include updating the phoenix aliases for assets.deploy and assets.build, so css is available outside of development.
@cblavier
Copy link
Contributor

cblavier commented Mar 2, 2023

Yes, I'll do that

@cblavier cblavier added the enhancement New feature or request label Mar 2, 2023
@cblavier cblavier self-assigned this Mar 14, 2023
@cblavier
Copy link
Contributor

I will improve the generator to add:

  • "tailwind storybook --minify", into mix.exs aliases
  • COPY storybook storybook into Dockerfile

@cblavier cblavier linked a pull request Mar 15, 2023 that will close this issue
improved mix phx.gen.storybook instructions #266
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cblavier cblavier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improved mix phx.gen.storybook instructions phenixdigital/phoenix_storybook
2 participants
@cblavier @LostKobrakai