Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests and test data for Bruker ivDr version 2 #76

Open
Gscorreia89 opened this issue Jun 24, 2021 · 0 comments
Open

Add unittests and test data for Bruker ivDr version 2 #76

Gscorreia89 opened this issue Jun 24, 2021 · 0 comments
Labels
enhancement New feature or request One week unittests Issues in the unittest, or code in need of testing
Projects
nPYc Development

Comments

@Gscorreia89
Copy link
Member

There are no unitests covering parsing of Bruker ivDr BI-QUANT v2.0 files.
We should:

  1. Add BI-QUANT v2.0 files to the current NMR data in unitest data
  2. Replicate the existing unitests to cover the v2.0 files as well. For back compatibility, the current v1.0 tests should be kept.
@Gscorreia89 Gscorreia89 added enhancement New feature or request unittests Issues in the unittest, or code in need of testing One week labels Jun 24, 2021
@Gscorreia89 Gscorreia89 added this to Backlog in nPYc Development Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request One week unittests Issues in the unittest, or code in need of testing
Projects
nPYc Development
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gscorreia89