@phenomic/plugin-bundler-webpack: react-helmet renderStatic() n…

…ow works as expected

Closes #1167

examples/react-app-getting-started/__tests__/index.js

@@ -1,4 +1,7 @@
 /* eslint-disable import/no-extraneous-dependencies */
+import path from "path";
+import fs from "fs";
+
 import globby from "globby";
 
 it("should build example correctly", () => {
@@ -34,4 +37,11 @@ it("should build example correctly", () => {
         !assetsBundlerFiles.includes(file)
     )
   ).toMatchSnapshot();
+
+  const file1 = fs.readFileSync(
+    path.join(__dirname, "..", "dist", "index.html"),
+    { encoding: "utf8" }
+  );
+  expect(file1).toContain("Fifth post");
+  expect(file1).toContain('<title data-react-helmet="true">Hello world');
 });

packages/plugin-bundler-webpack/src/index.js

@@ -31,6 +31,8 @@ const defaultExternals = [
   // to not bundle all deps in the static build (for perf)
   // the problem is that if people rely on node_modules for stuff
   // like css, this breaks their build.
+  //
+  // @todo find a better way than a whitelist
 
   // Glamor integration
   "glamor",
@@ -40,7 +42,9 @@ const defaultExternals = [
   "aphrodite",
   "aphrodite/no-important",
 
-  "react-native-web"
+  "react-native-web",
+
+  "react-helmet"
 ];
 
 const getWebpackConfig = (config: PhenomicConfig) => {