New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREACT Plugin/preset/example #1148

Open
MoOx opened this Issue Aug 31, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@MoOx
Member

MoOx commented Aug 31, 2017

We can probably reuse a lot of the react plugin (if not everything).

@marcelorl

This comment has been minimized.

Show comment
Hide comment
@marcelorl

marcelorl Oct 1, 2017

Can I take this one?

marcelorl commented Oct 1, 2017

Can I take this one?

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Oct 2, 2017

Member

@marcelorl Sure! Do not hesitate to ask!
One thing I would like to do: avoid using preact-compat, but not sure if that's easy if we want to rely on react-router. Feel free to discuss any questions you have here, on our chat!

Member

MoOx commented Oct 2, 2017

@marcelorl Sure! Do not hesitate to ask!
One thing I would like to do: avoid using preact-compat, but not sure if that's easy if we want to rely on react-router. Feel free to discuss any questions you have here, on our chat!

@drazik

This comment has been minimized.

Show comment
Hide comment
@drazik

drazik Nov 25, 2017

Contributor

@marcelorl did you start working on it ? If yes, I can help if you want. Otherwise, I can start the work :)

Contributor

drazik commented Nov 25, 2017

@marcelorl did you start working on it ? If yes, I can help if you want. Otherwise, I can start the work :)

@MoOx MoOx removed the Hacktoberfest label Dec 2, 2017

@MoOx MoOx added the plugin label May 4, 2018

@drazik

This comment has been minimized.

Show comment
Hide comment
@drazik

drazik Jun 2, 2018

Contributor

I just started to work on this one. Will keep you updated as soon as I have something working. I may have a lot of questions to ask during my work on it.

Contributor

drazik commented Jun 2, 2018

I just started to work on this one. Will keep you updated as soon as I have something working. I may have a lot of questions to ask during my work on it.

@jcayzac

This comment has been minimized.

Show comment
Hide comment
@jcayzac

jcayzac Jun 24, 2018

Avoid using preact-compat, but not sure if that's easy if we want to rely on react-router.

react-router works directly with preact, see https://codepen.io/developit/pen/BWxepY?editors=0010

jcayzac commented Jun 24, 2018

Avoid using preact-compat, but not sure if that's easy if we want to rely on react-router.

react-router works directly with preact, see https://codepen.io/developit/pen/BWxepY?editors=0010

@drazik

This comment has been minimized.

Show comment
Hide comment
@drazik

drazik Jun 24, 2018

Contributor

Yes but phenomic uses react-router 3, which is not compatible with preact without preact-compat AFAIK

Contributor

drazik commented Jun 24, 2018

Yes but phenomic uses react-router 3, which is not compatible with preact without preact-compat AFAIK

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Jun 24, 2018

Member
Member

MoOx commented Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment