Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

PREACT Plugin/preset/example #1148

Closed
MoOx opened this issue Aug 31, 2017 · 8 comments
Closed

PREACT Plugin/preset/example #1148

MoOx opened this issue Aug 31, 2017 · 8 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Aug 31, 2017

We can probably reuse a lot of the react plugin (if not everything).

@marcelorl
Copy link

marcelorl commented Oct 1, 2017

Can I take this one?

@MoOx
Copy link
Owner Author

MoOx commented Oct 2, 2017

@marcelorl Sure! Do not hesitate to ask!
One thing I would like to do: avoid using preact-compat, but not sure if that's easy if we want to rely on react-router. Feel free to discuss any questions you have here, on our chat!

@drazik
Copy link
Contributor

drazik commented Nov 25, 2017

@marcelorl did you start working on it ? If yes, I can help if you want. Otherwise, I can start the work :)

@MoOx MoOx removed the Hacktoberfest label Dec 2, 2017
@MoOx MoOx added the plugin label May 4, 2018
@drazik
Copy link
Contributor

drazik commented Jun 2, 2018

I just started to work on this one. Will keep you updated as soon as I have something working. I may have a lot of questions to ask during my work on it.

@jcayzac
Copy link

jcayzac commented Jun 24, 2018

Avoid using preact-compat, but not sure if that's easy if we want to rely on react-router.

react-router works directly with preact, see https://codepen.io/developit/pen/BWxepY?editors=0010

@drazik
Copy link
Contributor

drazik commented Jun 24, 2018

Yes but phenomic uses react-router 3, which is not compatible with preact without preact-compat AFAIK

@MoOx
Copy link
Owner Author

MoOx commented Jun 24, 2018 via email

@MoOx
Copy link
Owner Author

MoOx commented Nov 26, 2018

Not a priority atm. Feel free to discuss below.

@MoOx MoOx closed this as completed Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants