Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Default markdown engine: some html does not work in markdown files #817

Closed
MoOx opened this issue Oct 11, 2016 · 6 comments
Closed

Default markdown engine: some html does not work in markdown files #817

MoOx opened this issue Oct 11, 2016 · 6 comments
Labels
bug

Comments

@MoOx
Copy link
Owner

MoOx commented Oct 11, 2016 •
edited

Does not work

<iframe src="//slides.com/maxdow/toulousejs13/embed" width="576" height="420" scrolling="no" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>

(displayed as raw code, wrapped by a p)

Works

<iframe src="//slides.com/maxdow/toulousejs13/embed" width="576" height="420" scrolling="no" frameborder="0" webkitallowfullscreen="true" mozallowfullscreen="true" allowfullscreen="true">
</iframe>

// or

<iframe src="//slides.com/maxdow/toulousejs13/embed" width="576" height="420" scrolling="no" frameborder="0">
</iframe>

It seems current parser does not like attributes without value

(scroll right to see the diff)
@MoOx MoOx added the bug label Oct 11, 2016
@MoOx MoOx mentioned this issue Oct 11, 2016
Closed
@bherila
Copy link

bherila commented Jul 7, 2017

FYI: Appears that <button> suffers from the same problem.

@daine
Copy link

daine commented Jul 11, 2017

Most of the html tags I've tried so far doesn't work either.

<div> <p> <span> - Doesn't show up
<a> - Shows up, but only as a paragraph (<p>), so no links.

@MoOx
Copy link
Owner Author

MoOx commented Jul 11, 2017

Which version of phenomic?

@daine
Copy link

daine commented Jul 11, 2017

I'm using version 1.0.0-alpha.4

@MoOx
Copy link
Owner Author

MoOx commented Sep 7, 2017

On it.

@MoOx MoOx mentioned this issue Sep 20, 2017
Closed
MoOx added a commit that referenced this issue Sep 26, 2017
@MoOx
@phenomic/plugin-transform-markdown: allow custom markup
1bd1d2f 
This plugin now use [unified](http://unifiedjs.github.io) directly instead of [remark](https://github.com/wooorm/remark) so we can mix remark with [rehype](https://github.com/wooorm/rehype) to allow custom markup.
This will open up usage of custom react components when rendering markdown tree with a custom mapping.

Closes [#187](#817) Closes [#1098](#1098)
@MoOx
Copy link
Owner Author

MoOx commented Sep 26, 2017

Closed by 1bd1d2f

@MoOx MoOx closed this as completed Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MoOx @daine @bherila