Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard hint may be out of dev bounds with some query parameters #549

Open
Nancy-Salpepi opened this issue Oct 21, 2021 · 5 comments
Open

Comments

@Nancy-Salpepi
Copy link

Test device
iMac

Operating System
10.15.7

Browser
chrome

Problem description
phetsims/qa#721

Seen when using stringTest=long and stringTest=double: After switching from mouse to keyboard nav, the keyboard nav hint to grab the balloon can be partially out of dev bounds.

Steps to reproduce

  1. Using mouse, move balloon across sweater and release at leftmost side of screen
  2. Use tab key to highlight balloon
    OR
  3. Remove wall
  4. Use mouse to move balloon to rightmost side of screen
  5. Use tab key to highlight balloon

Visuals

Screen Shot 2021-10-21 at 2 34 27 PM
Screen Shot 2021-10-21 at 2 36 13 PM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Balloons and Static Electricity‬ URL: https://phet-dev.colorado.edu/html/balloons-and-static-electricity/1.5.0-rc.2/phet/balloons-and-static-electricity_all_phet.html Version: 1.5.0-rc.2 2021-10-11 21:55:48 UTC Features missing: applicationcache, applicationcache, touch User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36 Language: en-US Window: 1288x875 Pixel Ratio: 1/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@jessegreenberg
Copy link
Contributor

The published sim used to shift he cue around based on the bounds. I am not sure when we lost this, maybe when we switched over to using GrabDragInteraction.

Published sim:
image

@jessegreenberg
Copy link
Contributor

The GrabDragInteraction does not have support for changing the position of the grabCueNode after the GrabDragInteraction has been constructed. Unfortunately it does not look trivial to add this to GrabDragInteraction.

@emily-phet @terracoda are you OK publishing BASE with this regression or is this important to fix?

@emily-phet
Copy link

I don't think this should be a blocking issue for BASE publication.

@emily-phet emily-phet removed their assignment Oct 21, 2021
@jessegreenberg
Copy link
Contributor

Thanks @emily-phet. Closing this issue.

@jessegreenberg
Copy link
Contributor

@KatieWoe suggested leaving open as deferred, reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants