Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use standard PhET namespace #78

Closed
pixelzoom opened this issue May 12, 2016 · 1 comment
Closed

use standard PhET namespace #78

pixelzoom opened this issue May 12, 2016 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 12, 2016 •
edited
Loading

This sim appears to have its own non-standard namespace (see namespace.js), so it wasn't easily addressed when adding a standard PhET namespace to other sims in phetsims/joist#307. @jonathanolson will need to handle this.

This sim will continue to fail automated testing until this is addressed.
@pixelzoom pixelzoom mentioned this issue May 12, 2016
Closed
@pixelzoom pixelzoom changed the title use PhET convention for namespace use standard PhET namespace May 12, 2016
@jonathanolson jonathanolson removed their assignment Sep 8, 2016
@Denz1994
Copy link
Contributor

Denz1994 commented Jan 9, 2020

This issue is stale. Automated testing hasn't been failing due to namespace issues.

@Denz1994 Denz1994 closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @pixelzoom @Denz1994