Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Set Value' for prediction arrows can exceed maximum #109

Closed
Nancy-Salpepi opened this issue Mar 24, 2022 · 3 comments
Closed

'Set Value' for prediction arrows can exceed maximum #109

Nancy-Salpepi opened this issue Mar 24, 2022 · 3 comments
Assignees
Labels
dev:phet-io type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
Chrome

Problem description
For phetsims/qa#789 and part of the PhET-iO needs for 3/30 #105:

The 'Get Value' aspect of the model.medianPredictionProperty and model.medianPredictionProperty seems to working correctly. However the 'Set Value' can exceed the maximum value of 15.

Visuals
Screen Shot 2022-03-24 at 4 15 46 PM

@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Mar 24, 2022
@chrisklus chrisklus added this to the Classroom prototype milestone Mar 28, 2022
@samreid
Copy link
Member

samreid commented Mar 28, 2022

The sim has a correct guard for the values (range of 1 to 15). However, the changes in https://github.com/phetsims/studio/issues/253 seem to require that studio is launched with ?phetioDebug which is not the default and there is no documentation for. @zepumph can you please recommend how to proceed?

@samreid samreid assigned zepumph and unassigned samreid and chrisklus Mar 28, 2022
@zepumph
Copy link
Member

zepumph commented Mar 29, 2022

I would honestly just close this issue. We want to develop more assertive error handling over there so that phetioDebug is not required. This is a known issue. I'm happy to leave open, but I don't see any sim-specific additional info that this issue adds to the problem. Over there, we will most likely try to eagerly check range before an assertion would happen, and provide studio with the proper error message/handling BEFORE the value was even set outside of the range.

@zepumph zepumph assigned samreid and unassigned zepumph Mar 29, 2022
@chrisklus
Copy link
Contributor

Thanks @zepumph! @samreid and I are going to close this issue. Clients will be able to set outside of the range for the April version, but this will be fixed for the production version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants