You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem description
For phetsims/qa#789 and part of the PhET-iO needs for 3/30 #105:
The 'Get Value' aspect of the model.medianPredictionProperty and model.medianPredictionProperty seems to working correctly. However the 'Set Value' can exceed the maximum value of 15.
Visuals
The text was updated successfully, but these errors were encountered:
The sim has a correct guard for the values (range of 1 to 15). However, the changes in https://github.com/phetsims/studio/issues/253 seem to require that studio is launched with ?phetioDebug which is not the default and there is no documentation for. @zepumph can you please recommend how to proceed?
I would honestly just close this issue. We want to develop more assertive error handling over there so that phetioDebug is not required. This is a known issue. I'm happy to leave open, but I don't see any sim-specific additional info that this issue adds to the problem. Over there, we will most likely try to eagerly check range before an assertion would happen, and provide studio with the proper error message/handling BEFORE the value was even set outside of the range.
Thanks @zepumph! @samreid and I are going to close this issue. Clients will be able to set outside of the range for the April version, but this will be fixed for the production version.
Test device
MacBook Air (m1 chip)
Operating System
12.3
Browser
Chrome
Problem description
For phetsims/qa#789 and part of the PhET-iO needs for 3/30 #105:
The 'Get Value' aspect of the model.medianPredictionProperty and model.medianPredictionProperty seems to working correctly. However the 'Set Value' can exceed the maximum value of 15.
Visuals
![Screen Shot 2022-03-24 at 4 15 46 PM](https://user-images.githubusercontent.com/87318828/160003337-02104252-33ce-4ded-ba81-7b427d50fb61.png)
The text was updated successfully, but these errors were encountered: