Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument ElementFollower for phet-io #392

Open
jbphet opened this issue Oct 6, 2020 · 0 comments
Open

Instrument ElementFollower for phet-io #392

jbphet opened this issue Oct 6, 2020 · 0 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 6, 2020

#388 describes some problems, as well as a "workaround-ish" solution to problems where the thermometers don't always manifest the correct element-following behavior in the state wrapper. The solution that was used to solve the problem involved monitoring the isSettingPhetioStateProperty property and doing some very specific state updates at the beginning and end of state settings. @zepumph and I discussed this, and we agreed that it would be way better to instrument ElementFollower so that its state is included in part of the state setting operation.

@zepumph said he was up for giving this a try. As of this moment, we are only planning to do this on master, since we have what appears for now to be a working solution on the 1.4 branch, and publication from that branch is imminent.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants