Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voicing skips over portion of 'Move Book' section in keyboard dialog #262

Closed
Nancy-Salpepi opened this issue Oct 13, 2021 · 3 comments
Closed

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook air (m1 chip)

Operating System
iOS 11.6

Browser
safari 15

Problem description
phetsims/qa#717

Voicing skips over 'Move Slower' keyboard keys in keyboard dialog.

Steps to reproduce

  1. Turn on voicing
  2. Open Keyboard Shortcuts dialog
  3. Tab to or click on 'Move Book' section

Visuals

moveslower.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1440x675 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@zepumph
Copy link
Member

zepumph commented Nov 10, 2021

This was fixed by phetsims/scenery-phet#711, out for review now.

@Nancy-Salpepi
Copy link
Author

The entire keyboard shortcuts dialog is now read with Voicing.
I did notice that there is no pause at all after the "D" in WASD and "Move Slower". I tried on both safari and chrome with my mac and with 3 different voices.

keyboarddialog.mov

@zepumph
Copy link
Member

zepumph commented Mar 4, 2022

I hear that too! When I use ?printVoicingResponses this is what is being spoken:

Move Book, Move grabbed book or zoomed-in book up, left, down, or right with Arrow keys,
or with letter keys W, A, S, or D. Move slower with Shift plus Arrow keys, or Shift plus letter keys W, A, S, or D.

I see the period there. Voices are sometimes weird, but I think we are doing the best we can. Closing

@zepumph zepumph closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants