Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance problem in State wrapper. #243

Open
pixelzoom opened this issue May 14, 2024 · 1 comment
Open

Performance problem in State wrapper. #243

pixelzoom opened this issue May 14, 2024 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

As noted in #231 (comment), performance in the State wrapper is jerky. Whenever state is restored, the Downstream sim has a noticeable pause. The pause gets longer as the number of particles increases, so it's a scalability problem. (I have not quantified how much longer, but it's qualitatively obvious when running the State wrapper.)

Particle instrumentation uses the same pattern as Projectiles in PDL. That sim experiences the same pause in the State wrapper. @samreid said that the PDL team did not choose to optimize for that case, so perhaps we can also ignore this for Gas Properties. But I am not clear on what uses cases would be impacted by this performance problem, whether this is problem is symptomatic of the pattern adopted from PDL, or whether there's an alternative pattern that would be more performant.

Assigning to @arouinfar @Nancy-Salpepi to decide whether we need to address this.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented May 28, 2024

5/28/24 status meeting with @arouinfar @kathy-phet @KatieWoe @pixelzoom

There is no current use case that this will impact. Playback will probably be a problem, and it's unfortunate that this approach (also used in PDL @samreid @matthew-blackman ) is not scalable. But until a use case is identified, this issue is deferred, and we'll skip it for the 1.1 release #191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants