Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance sign-off #191

Closed
pixelzoom opened this issue Aug 20, 2020 · 4 comments
Closed

performance sign-off #191

pixelzoom opened this issue Aug 20, 2020 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 20, 2020

This is listed as a "standard GitHub issue" in the code-review checklist. The lead designer must sign off on performance.

@pixelzoom
Copy link
Contributor Author

#60 and #140 are the 2 cases that were performance concerns. A lot of work was done to improve PhET-iO performance, and it now feels acceptable to me. So over to @amanda-phet for performance sign-off. I'm not quite sure how sign-off is going to work without access to PhET's test devices. Let me know if you want to discuss.

@amanda-phet
Copy link
Contributor

@ariel-phet Can you also help sign off on this one? I've read the performance issues and commented, and if @pixelzoom thinks it's acceptable then I'm inclined to accept the current performance status. #140 is a little bit of a usability issue combined with performance, and #60 seems fine to me.

@amanda-phet
Copy link
Contributor

Oops, #166 is the usability issue. They are so similar I confused them.

@ariel-phet
Copy link

Looked over the issues, I think all is in a good place (certainly for PhET brand). It sounds like @pixelzoom has some thoughts for potential optimizations as this sim gets moved towards the iO dev release, but I think even without those we would be in pretty solid shape.

Signing off and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants