Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only redrawn texts in FormulaNode on change #58

Closed
zepumph opened this issue Jun 25, 2017 · 2 comments
Closed

Only redrawn texts in FormulaNode on change #58

zepumph opened this issue Jun 25, 2017 · 2 comments
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Jun 25, 2017

A TODO in the code:

// TODO: Performance: consider not updating the matrix if it hasn't changed (if textData.x, textData.scaleA, and textData.scaleB haven't changed)

I'm not sure if we need to work on performance here. The profiler is showing 58 to 60 FPS consistently with fuzzMouse.
@zepumph zepumph self-assigned this Jun 25, 2017
@zepumph zepumph removed their assignment Jun 25, 2017
@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

We updated where the matrix was being set in f1cdcbd and I just don't think performance is going to be a problem here. Closing.

@zepumph zepumph closed this as completed Jun 26, 2017
@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

from code review: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph