Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Molecule Polarity 1.0.0-dev.23 #21

Closed
pixelzoom opened this issue Jul 17, 2017 · 3 comments
Closed

Dev test: Molecule Polarity 1.0.0-dev.23 #21

pixelzoom opened this issue Jul 17, 2017 · 3 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 17, 2017

This is the first dev test of Molecule Polarity.

Dev test:
http://www.colorado.edu/physics/phet/dev/html/molecule-polarity/1.0.0-dev.23/molecule-polarity_en.html

iFrame test:
http://www.colorado.edu/physics/phet/dev/html/molecule-polarity/1.0.0-dev.23/molecule-polarity_en-iframe.html

This sim was ported from Java, and consists of 3 screens.

The first 2 screens ("Two Atoms", "Three Atoms") have the following differences from the Java version:
• Turning the E-field on/off will show/hide the plates. See phetsims/molecule-polarity#52. In the Java version, the plates were always visible, and the polarity indicators were shown/hidden.
• When the sim starts, "cueing arrows" are shown around the molecules. Their behavior is specified in phetsims/molecule-polarity#50 (comment). In the Java version, the overall behavior was different, and the rotation arrows were a custom cursor.

The third screen ("Real Molecules") is not fully implemented, since we don't have a 3D molecule viewer for HTML5. Since it's likely to be some time before a 3D viewer is implemented, PhET decided to publish without that functionality, see phetsims/molecule-polarity#27. A dialog in the "Real Molecules" screen directs the user to the Java version.

Sim-specific query parameters are documented in MPQueryParameters.js. Ignore the realMolecules query parameter, there is no need to test it.

I have tested primarily on Chrome, Safari and Mobile Safari. Please spot check on other platforms. This sim does not currently use WebGL.

Please mention this issue in any GitHub issues that you create.

Assigned to @ariel-phet for prioritization.

@pixelzoom pixelzoom added the QA:dev-test Dev test before an RC label Jul 17, 2017
@pixelzoom
Copy link
Contributor Author

Since this sim was ported in 2014, there is no "Terminology" section per se in the documentation. You might find it useful to skim through model.md, followed by implementation-notes.md, before testing this sim.

@phet-steele
Copy link
Contributor

@pixelzoom, this testing is done.

@pixelzoom
Copy link
Contributor Author

Thank you @phet-steele and QA team - you found some good stuff.

All related issues have been addressed and are closed. So closing this issue.

@emily-phet We're ready to proceed to RC testing as soon as phetsims/molecule-polarity#73 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants