Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check login status on page navigations and on publish #413

Open
jbphet opened this issue Jun 13, 2023 · 3 comments
Open

Check login status on page navigations and on publish #413

jbphet opened this issue Jun 13, 2023 · 3 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 13, 2023

While working with me on #412 @mattpen observed that the Rosetta client code isn't checking login status on page navigations. He said that it should. The issue also relates to how a publication request can be sent to the server with bogus user ID information, probably because the user's session has timed out.

For security reasons, we should probably improve Rosetta's behavior such that it does check login info on a page navigation and on publish requests and, if a user's session has expired, prompt them to re-enter their login credentials before allowing the request.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 13, 2023

Since this is likely to be a fairly significant effort, I'll put it on the project backlog and request time for it in an upcoming sprint.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 10, 2023

This was chosen as an item for the current sprint, so I'm assigning it to myself and starting on it.

@jbphet
Copy link
Contributor Author

jbphet commented Jul 21, 2023

After further review, there are higher priority issues that should be addressed in Rosetta before tackling this, specifically some problems that have been recently reported by translators. I'm going to remove the high priority label, but leave the issue assigned to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants