Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Font Awesome SVG data from FontAwesomeNode to sherpa/ #82

Closed
samreid opened this issue Dec 11, 2020 · 2 comments
Closed

Move Font Awesome SVG data from FontAwesomeNode to sherpa/ #82

samreid opened this issue Dec 11, 2020 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented Dec 11, 2020

From #81

@jonathanolson said:

My concern is that the derived work is specifically embedded and checked into our MIT'ed source code, e.g. https://github.com/phetsims/sun/blob/master/js/FontAwesomeNode.js

I said:

Maybe it would be more inline with PhET's process to put the font awesome data in the "sherpa" repo, which already supports various 3rd party licensing.

@kathy-phet said:

I thought sherpa was just where we tracked the licenses? Is that were we put the third party images when we have them? If so, yes.

I said:

Sherpa contains the 3rd party licenses as well as the 3rd party code.

@kathy-phet replied:

If FontAwesome svgs can live there that is perfect.

@samreid
Copy link
Member Author

samreid commented Dec 11, 2020

In the commit, I moved the font awesome svg data from FontAwesomeNode to sherpa. This was the "bare minimum" which kept the data in same form. We will need further changes to accommodate new data from Font Awesome 5.0. But I think that should be a new issue. @jonathanolson can you please review this minor change?

@jonathanolson
Copy link
Contributor

This looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants