Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PhetioCapsule phetioType to phetioValueType #276

Open
pixelzoom opened this issue Oct 21, 2022 · 1 comment
Open

Change PhetioCapsule phetioType to phetioValueType #276

pixelzoom opened this issue Oct 21, 2022 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

Should PhetioCapsule API be changed from phetioType to phetioValueType, as was done for DerivedProperty?

Example in PhetMenu.ts:

    const aboutDialogCapsule = new PhetioCapsule( ..., {
      ...
      phetioType: PhetioCapsule.PhetioCapsuleIO( Dialog.DialogIO )
    } );

The PhetioCapsule.PhetioCapsuleIO bit is required in all cases. So why not change to:

-      phetioType: PhetioCapsule.PhetioCapsuleIO( Dialog.DialogIO )
+      phetioValueType: Dialog.DialogIO
@samreid
Copy link
Member

samreid commented Feb 25, 2023

Adding to https://github.com/phetsims/phet-io/issues/1914 and self-unassigning.

@samreid samreid removed their assignment Feb 25, 2023
@zepumph zepumph removed their assignment Feb 27, 2023
@zepumph zepumph self-assigned this Jun 23, 2023
@zepumph zepumph removed their assignment Aug 17, 2023
@brent-phet brent-phet self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants