We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to code review #259, and #279.
SlitsControlPanel has some inadequate names for Ranges.
SlitsControlPanel
These are Ranges for slit width, and should be renamed to indicate that, e.g. waterSlitWidthRange.
waterSlitWidthRange
const waterRange = new Range( 0.5, 2.5 ); // cm const soundRange = new Range( 20, 160 ); const lightRange = new Range( 200, 1600 );
These are Ranges for slit separation. Consider renaming to (e.g) waterSlitSeparationRange.
waterSlitSeparationRange
const waterSeparationRange = new Range( 1, 5 ); const soundSeparationRange = new Range( 40, 320 ); // cm const soundSeparationRange = new Range( 40, 320 ); // cm const lightSeparationRange = new Range( 400, 3200 );
The text was updated successfully, but these errors were encountered:
In #279 the slit width ranges were moved to the model, and now appear like this (e.g.,):
slitWidthRange: new Range( 0.5, 2.5 ), // cm
and
sourceSeparationRange: new Range( 1, 5 ), // cm
Please review.
Sorry, something went wrong.
👍 Closing.
pixelzoom
No branches or pull requests
Related to code review #259, and #279.
SlitsControlPanel
has some inadequate names for Ranges.These are Ranges for slit width, and should be renamed to indicate that, e.g.
waterSlitWidthRange
.These are Ranges for slit separation. Consider renaming to (e.g)
waterSlitSeparationRange
.The text was updated successfully, but these errors were encountered: