Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use better names for Ranges in SlitsControlPanel #284

Closed
pixelzoom opened this issue Dec 19, 2018 · 2 comments
Closed

use better names for Ranges in SlitsControlPanel #284

pixelzoom opened this issue Dec 19, 2018 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 19, 2018

Related to code review #259, and #279.

SlitsControlPanel has some inadequate names for Ranges.

These are Ranges for slit width, and should be renamed to indicate that, e.g. waterSlitWidthRange.

const waterRange = new Range( 0.5, 2.5 ); // cm
const soundRange = new Range( 20, 160 );
const lightRange = new Range( 200, 1600 );

These are Ranges for slit separation. Consider renaming to (e.g) waterSlitSeparationRange.

const waterSeparationRange = new Range( 1, 5 );
const soundSeparationRange = new Range( 40, 320 ); // cm
const soundSeparationRange = new Range( 40, 320 ); // cm
const lightSeparationRange = new Range( 400, 3200 );
@samreid
Copy link
Member

samreid commented Dec 29, 2018

In #279 the slit width ranges were moved to the model, and now appear like this (e.g.,):

slitWidthRange: new Range( 0.5, 2.5 ), // cm

and

sourceSeparationRange: new Range( 1, 5 ), // cm

Please review.

@pixelzoom
Copy link
Contributor Author

👍 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants