Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use common-code slider #132

Closed
pixelzoom opened this issue Mar 5, 2019 · 1 comment
Closed

use common-code slider #132

pixelzoom opened this issue Mar 5, 2019 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

While working on SUN/Slider changes in phetsims/sun#478, I discovered that wave-on-a-string has its own slider implementation WAVE_ON_A_STRING/Slider. The screenshot below shows the 2 places where it's used. This should definitely be replaced with SUN/Slider, or possibly SCENERY_PHET/NumberControl. And this is a prerequisite to a11y and phet-io instrumentation.
@jonathanolson jonathanolson mentioned this issue Jan 31, 2020
Closed
@jonathanolson
Copy link
Contributor

Using NumberControl now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @pixelzoom