Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion for simpler/more correct MacroArgs #80

Open
nschloe opened this issue Feb 15, 2022 · 0 comments
Open

suggestion for simpler/more correct MacroArgs #80

nschloe opened this issue Feb 15, 2022 · 0 comments

Comments

@nschloe
Copy link

nschloe commented Feb 15, 2022

Right now, macro args are represented as

ParsedMacroArgs(
    argspec="{",
    argnlist=[...],
)

where len(argspec) == len(argnlist). My suggestion would be to slightly alter this structure to

[
    MacroArg(
        argspec="[",
        arg=#...
    ),
    MacroArg(
        argspec="{",
        arg=#...
    ),
]

This has the advantage that illegal state are irrepresentable (len(argspec) == len(argnlist) is implicit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant