New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current automenu 'list-group' doesn't support link hover states. #1057
Comments
An example of how to accomplish the above https://gist.github.com/peshi/82997acb75cd1107c959
|
@peshi should we extend the template? |
@phiamo I'll check so that it doesn't interfere with intended behaviour of automenu and create a PR. |
@peshi thanks a lot! |
@peshi did we already merge a pr for this ? |
@phiamo Nope, that hasn't been merged, if I remember correctly we have to lift the 'list-group' from automenu and extend the template to replace |
@peshi is there a PR |
@phiamo Hi, I have a solution locally (twig based) - but it will replace the current implementation that is specified MenuDecorator and MenuConverter. I would like to get some input from the contributor of automenu regarding this issue, maybe there is a way not to use twig. You could try the gist I pasted above. |
I had originally created the menu extension and then @phiamo created the auto menu I believe and moved the menu extension to a separate class so it could be used in a couple ways. I think Twig would be the best bet. If you check out: https://github.com/KnpLabs/KnpMenu/blob/master/src/Knp/Menu/Resources/views/knp_menu.html.twig#L25 We could override that block and change the |
There should be an option to be able to decorate automenu 'list-group' with div instead of ul in order to benefit from Bootstraps linked list items.
Ref: https://github.com/twbs/bootstrap-sass/blob/master/assets/stylesheets/bootstrap/_list-group.scss#L41
Example.
The text was updated successfully, but these errors were encountered: