HorizontalFormTypeExtension doesn’t play well with CollectionType in latest Symfony stable

[corphi]

With symfony/symfony#18317 collection form prototypes have their parent set, but there is no inverse direction, i.e. the prototype is not part of the collection children.

HorizontalFormTypeExtension sets the horizontal view variable on root forms and bubbles its value to the form children. As prototypes are no longer root forms, their value stays null and evaluates to false in the template.

[rejsmont]

Current workaround is to set 'horizontal' => true for each child, though this is not clean and optimal solution. Also there is a duplicate issue #1176.

[MichaelMure]

Hi, I described my problem in Symfony's issues (symfony/symfony#19355) and a dev suggested that it could be an usage error by MopaBootsrap (symfony/symfony#19355 (comment))

Can someone experienced here have a look on the issue ?

[HeahDude]

Hi there, I confirm that a prototype should not be considered as a root form.

It used to work because of a kind of bug in the prototype creation from CollectionType, is there anyway you can fix it in your code? Thanks.

[isometriks]

@HeahDude can you try my PR?

#1180

Check here to grab it if you don't know how: https://help.github.com/articles/checking-out-pull-requests-locally/

I just added a bunch more tests. I think it should be working properly now.

[HeahDude]

@isometriks thanks for taking care of this issue :)

Actually I don't use this lib, I was just saying that this "regression" is a bug fix on symfony side so it should be fix on "this" side. Thanks again, cheers!

[isometriks]

Ah ok, thanks!

[isometriks]

@corphi @rejsmont @MichaelMure I think I've solved this, try out v3.1.0 and let me know if you have better luck. You shouldn't have to set horizontal on all children anymore.

[MichaelMure]

It does work for me, thanks !