Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart #4

Closed
ontrou opened this issue Mar 21, 2021 · 6 comments
Closed

Pie chart #4

ontrou opened this issue Mar 21, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@ontrou
Copy link

ontrou commented Mar 21, 2021

Is there any chance that you'll introduce a pie chart type?

@phibr0
Copy link
Owner

phibr0 commented Mar 21, 2021

I could add a Pie Chart to this Plugin, but there is already a Pie Chart in Mermaid which comes with Obsidian by default.
https://mermaid-js.github.io/mermaid/#/pie

    ```mermaid
    pie title Pets adopted by volunteers
        "Dogs" : 386
        "Cats" : 85
        "Rats" : 15
    ```

@phibr0 phibr0 added the enhancement New feature or request label Mar 21, 2021
@ontrou
Copy link
Author

ontrou commented Mar 21, 2021

I do use Mermaid now. But I am looking at your roadmap to be able to create a chart from a table, which would make charts from your plugin much more useful.

The other thing I dislike about Mermaid pie charts is that the way it is labelled. It is sometimes difficult to differentiate the default colours, which you have to do to identify the labels. I've noticed Chartist directly labels its pie charts.

@phibr0
Copy link
Owner

phibr0 commented Mar 21, 2021

I will take a look into adding Pie Chart support now. To generate the Chart from a Table i would somehow need to parse a table which I dont know how yet.

@phibr0
Copy link
Owner

phibr0 commented Mar 21, 2021

I added the Pie Chart with the newest Update. Take a look at the Readme for further instructions please.

@phibr0 phibr0 closed this as completed Mar 21, 2021
@ontrou
Copy link
Author

ontrou commented Mar 21, 2021

Thank you so much @phibr0 It looks great.

BTW, in the Readme, you've written: "The Line Chart works a bit differently, it only accepts..." Of course you meant "The Pie Chart..."

@phibr0
Copy link
Owner

phibr0 commented Mar 21, 2021

Thanks! Fixed the Readme in 711cbc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants