Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh chart colors app switches between light/dark mode #45

Closed
kepano opened this issue Feb 26, 2022 · 4 comments
Closed

Refresh chart colors app switches between light/dark mode #45

kepano opened this issue Feb 26, 2022 · 4 comments

Comments

@kepano
Copy link

kepano commented Feb 26, 2022

This is a small QoL improvement I noticed which would be nice.

Currently when the user switches between light/dark mode, the chart colors don't change unless you close/reopen the note.

@phibr0
Copy link
Owner

phibr0 commented Feb 27, 2022

I also noticed that. Already looking into it, but I want to make sure to not mess up the life-cycle management again 😅

@phibr0 phibr0 added this to to do in Obsidian Plugins Mar 1, 2022
@phibr0
Copy link
Owner

phibr0 commented Mar 17, 2022

Is there an Event I can listen to for theme changes? Or do I need a MutationObserver on the body element to check for the theme class

@phibr0
Copy link
Owner

phibr0 commented Mar 17, 2022

Thanks a lot!

@phibr0 phibr0 closed this as completed in ab844c1 Mar 17, 2022
Obsidian Plugins automation moved this from to do to done Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

2 participants