Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding current date to custom instructions #52

Closed
ashpreetbedi opened this issue Jan 24, 2024 Discussed in #51 · 2 comments
Closed

Adding current date to custom instructions #52

ashpreetbedi opened this issue Jan 24, 2024 Discussed in #51 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ashpreetbedi
Copy link
Contributor

Discussed in https://github.com/orgs/phidatahq/discussions/51

Originally posted by adieyal January 19, 2024
It could be useful to add a flag to the assistant's custom instructions to include the current date to enable queries relative to time, e.g. Where there any notable trends in last month's sales?

I've added mine to extra_instructions, i.e.

extra_instructions=[f"The current date is {datetime.now()}"]

but it might be a common enough requirement to warrant adding as a bool on Assistant

class Assistant(BaseModel):
    ...
    add_current_time: bool = False
@ashpreetbedi ashpreetbedi added enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2024
@ashpreetbedi
Copy link
Contributor Author

cc @adieyal

@ashpreetbedi
Copy link
Contributor Author

Release with v2.3.6 @adieyal 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants