Install from .zip tile doesn't work from home screen widget

[MartijnKaijser]

This could be a core issue as you normally get the browse dialog which works from other places

[phil65]

core issue.

[razzeee]

We probably have no chance to not show that one on the home screen do we? I don't think that's an option that needs to be in the front seat.

[ksooo]

@tamland ping. just an observation, no idea how a proper fix must look like: https://github.com/xbmc/xbmc/blob/master/xbmc/filesystem/AddonsDirectory.cpp#L472 creating a non-folder item here leads to "PlayMedia" builtin called for this item when selected from the widget.

[tamland]

What 'tile' are we talking about..?

[razzeee]

New home screen in the second branch of this repo

[tamland]

Yeah.. I've said it before, you can't just take a random internal path, put it in directory provider and expect it work. You have to add support for it. Most likely the zip install is handled by the addon browser window.

[phil65]

@tamland Would it be possible to add support for it or should i switch back to static items instead of VFS?

[tamland]

Sure, it's possible to make it work with directory providers. Moving the things from https://github.com/xbmc/xbmc/blob/master/xbmc/addons/GUIWindowAddonBrowser.cpp to CAddonsDirectory is probably enough. And you have to think about how to handle change detection ofc. and if the current one is sufficient..

[phil65]

Will you have time to have a go at it? Otherwise I will probably go for the quick solution for now.
Thx in advance.

[tamland]

I'll file it in my todo list together with adding support for the repository directories which @HitcherUK added earlier;)

[phil65]

cool, thx a lot!

[razzeee]

I still think it shouldn't be on the homescreen at all :X

[ksooo]

I still think it shouldn't be on the homescreen at all

why? i think it should. I'm using it very often to install my own (not yet released or heavily patched) shit.

[razzeee]

I do too, but we're devs and we're not building a media center for devs, are we? I don't think a feature we just added a warning sign before should be front and center on the home screen.

[ksooo]

we're not building a media center for devs

we do! ;-)

[da-anda]

yes, should IMO be removed from home screen. I also use it, but it's more a "pro" feature and should be burried somewhere, like before.

[ksooo]

yes, should IMO be removed from home screen. I also use it, but it's more a "pro" feature and should be burried somewhere, like before.

imo not.

[Mike-KL]

After trying v2 and reporting in following thread, to be told known issue and to look here; I fully agree with Razzeee comments above that option should not be on home screen at top level.

http://forum.kodi.tv/showthread.php?tid=262144&pid=2463075#pid2463075

[ksooo]

@tamland any chance for a fix for this for Krypton (regardless whether it is removal or keep of the item in question)?

[tamland]

Don't know when I'll have time yet (and if we're removing zip it's more work finding a new place for it). But didn't we agree not to use this vfs path before it's been actually implemented?

[phil65]

@tamland just give me a heads-up whether it will get done in time for krypton, otherwise i will change that list to static items. Thx!