Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes processData() does not correctly classify 'market' and 'market-limit' orders #26

Open
petr-fedorov opened this issue Oct 4, 2018 · 2 comments
Assignees
Labels

Comments

@petr-fedorov
Copy link
Contributor

An order that started out as a market order, came to rest in the order book and has not been filled since then is classified as 'market' instead of 'market-limit'

@phil8192 phil8192 self-assigned this Oct 4, 2018
@petr-fedorov
Copy link
Contributor Author

Actually, I plan to submit a pull request to fix this one and the other issues I opened, so I will be more than happy if you consider it possible to assign all of them to me :-).

Essentially, I have 'depth' and 'trades' from Bitfinex then I reconstruct the order flow from them and pass the flow to processData() to get 'depth' and 'trades' back. Thus theoretically I know the correct output of processData() in advance and it helps to catch bugs. But practically the bugs are both in my code and in obAnalytics. It is difficult to fix them separately so I have to capture them first as issues.

@phil8192 phil8192 added the bug label Oct 9, 2018
@phil8192
Copy link
Owner

phil8192 commented Oct 9, 2018

Ah, great! I've been looking to make the package more generic and not so specific to Bitstamp. Lots of refactoring to come..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants